Optimise PostgresMetadataFetcher#283
Open
suddendust wants to merge 12 commits intohypertrace:mainfrom
Open
Conversation
suddendust
requested review from
avinashkolluru,
kotharironak,
puneet-traceable,
skjindal93 and
suresh-prakash
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=============================================
- Coverage 81.46% 55.94% -25.53%
+ Complexity 1532 1531 -1
=============================================
Files 241 241
Lines 7387 7379 -8
Branches 712 711 -1
=============================================
- Hits 6018 4128 -1890
- Misses 924 2849 +1925
+ Partials 445 402 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…store into optimiseMetaFetcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I observed that querying
information_schemafor table metadata was much slower than queryingpg_catalogfor the same. See the following logs:With
information_schema:With
pg_catalog:This is ~ 26x faster.
Testing
Tested both version in an sandbox env.
Checklist:
Documentation
https://dba.stackexchange.com/questions/302587/what-is-faster-pg-catalog-or-information-schema